chore(deps): replace ora and chalk with leaner alternatives #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1148 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 21 21
Lines 763 763
Branches 142 142
=======================================
Hits 587 587
Misses 122 122
Partials 54 54 ☔ View full report in Codecov by Sentry. |
erickzhao
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Hey @Namchee, thank you for taking the time to raise this PR! After some discussion with other maintainers, we've decided to decline this PR.
Our rationale is that bundle size alone is not a strong enough reason for replacing well-known packages that have a history of stability and consistent maintenance.
cc @electron/wg-ecosystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces
oraandchalkin favor ofnanospinnerandpicocolorswithout changing the current behavior of the CLI while reducing its size.Current dependency graph
Package Report